Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump hic pipeline v1.0.0 #20

Merged
merged 8 commits into from
May 6, 2019
Merged

bump hic pipeline v1.0.0 #20

merged 8 commits into from
May 6, 2019

Conversation

nservant
Copy link
Collaborator

@nservant nservant commented Apr 30, 2019

Many thanks to contributing to nf-core/hic!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/hic branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/hic/tree/master/.github/CONTRIBUTING.md

Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor remarks 👍

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
conf/test.config Outdated Show resolved Hide resolved
main.nf Show resolved Hide resolved
@apeltzer apeltzer merged commit be62a7d into master May 6, 2019
nservant added a commit that referenced this pull request Oct 7, 2019
update changelog for nf-core release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants