Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.4 review comments #508

Merged
merged 8 commits into from
Sep 15, 2023
Merged

2.4 review comments #508

merged 8 commits into from
Sep 15, 2023

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Sep 15, 2023

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 mentioned this pull request Sep 15, 2023
Merged
9 tasks
@github-actions
Copy link

github-actions bot commented Sep 15, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit f740af7

+| ✅ 155 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 2.4.0
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-09-15 12:45:50

@jfy133 jfy133 mentioned this pull request Sep 15, 2023
Merged
11 tasks
d4straub
d4straub approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@jfy133 @d4straub
Update CHANGELOG.md
f740af7 
Co-authored-by: Daniel Straub <42973691+d4straub@users.noreply.github.com>
prototaxites
prototaxites approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@prototaxites prototaxites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CarsonJM
CarsonJM approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@CarsonJM CarsonJM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jfy133 jfy133 merged commit f6cd09f into dev Sep 15, 2023
@jfy133 jfy133 deleted the 2.4-review-comments branch September 15, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarsonJM CarsonJM CarsonJM approved these changes

@d4straub d4straub d4straub approved these changes

@prototaxites prototaxites prototaxites approved these changes

@ramprasadn ramprasadn Awaiting requested review from ramprasadn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jfy133 @prototaxites @d4straub @CarsonJM