Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CHANGELOG after registry update (missed in previous PR) #512

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Update CHANGELOG after registry update (missed in previous PR) #512

merged 1 commit into from
Sep 25, 2023

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Sep 25, 2023

Update changelog
|

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 merged commit 3cd985b into dev Sep 25, 2023
@github-actions
Copy link

nf-core lint overall result: Failed ❌

Posted for pipeline commit 0a5b517

+| ✅ 152 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   2 tests had warnings |!
-| ❌   4 tests failed       |-

❌ Test failures:

  • files_unchanged - CODE_OF_CONDUCT.md does not match the template
  • files_unchanged - .github/CONTRIBUTING.md does not match the template
  • files_unchanged - .github/workflows/linting.yml does not match the template
  • multiqc_config - 'assets/multiqc_config.yml' does not contain a matching 'report_comment'.

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 2.4.0
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-09-25 16:24:16

@jfy133 jfy133 deleted the registry-update branch October 4, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jfy133