Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nextflow_schema.json #652

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Update nextflow_schema.json #652

merged 1 commit into from
Aug 20, 2024

Conversation

amizeranschi
Copy link
Contributor

Remove "=" sign from parameter value assignment

Previous instructions may lead to issues when the parameter initialized with an "=" sign is precedeted by a Boolean parameter. See the discussion here:
https://nfcore.slack.com/archives/CE9MS66BS/p1724141829294639?thread_ts=1724053876.586899&cid=CE9MS66BS

Remove "=" sign from parameter value assignment
Copy link

github-actions bot commented Aug 20, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 993ac6d

+| ✅ 307 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file [TODO: try and test using for --host_fasta and --host_genome]
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-08-20 09:56:41

Copy link
Contributor

@prototaxites prototaxites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@amizeranschi amizeranschi merged commit 225257b into dev Aug 20, 2024
15 checks passed
@amizeranschi amizeranschi deleted the amizeranschi-patch-1 branch August 20, 2024 12:16
@jfy133 jfy133 mentioned this pull request Aug 22, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants