-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.3.1 release #764
base: master
Are you sure you want to change the base?
3.3.1 release #764
Conversation
Post release version bump
Important! Template update for nf-core/tools v3.1.1
Use channel empty when no phix reference supplied because skipping
Fix QUAST MultiQC config
Important! Template update for nf-core/tools v3.1.2
Fix support for iGenomes
Important! Template update for nf-core/tools v3.2.0
Fix parameter input validation for file/directory based parameters
New version of metro map
Version bump for 3.3.1 release
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me!
A comment and a question:
- I could have commented earlier but as I see it now: The subway map gives me the impression that it's XOR between e.g. CheckM, Prokka and GTDB-Tk.
- I note that you added a comma after the last parameter to process calls -- are we supposed to do that now?
Thanks @erikrikarddaniel !
|
Because all those processes are shown as parallel paths. In other parts of the diagram there are places when one can skip a step indicated by a bubble to the step that can be skipped. It hence looks to me like one takes one path through those alternatives. But I'm certainly not an authority on this.
I see, good to know. |
|
[...]
Not really, but I don't want you to waste too much time on this... My view of these diagrams is the "particle view" of quantum physics, not the "wave view", i.e. I can take one path through the diagram. I suppose you made it this way because these steps are executed in parallel though. But, no big deal! |
Just bug fixes:
Added
Changed
TEMPLATE
(by @jfy133)TEMPLATE
(by @jfy133)Fixed
PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).