Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added PhiX and Lambda references to summary #89

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Added PhiX and Lambda references to summary #89

merged 1 commit into from
Aug 13, 2020

Conversation

skrakau
Copy link
Member

@skrakau skrakau commented Aug 12, 2020

Added phix_reference and lambda_reference parameters to summary.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/mag/tree/master/.github/CONTRIBUTING.md

ggabernet
ggabernet approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine by me :)

@skrakau skrakau merged commit 8586c49 into nf-core:dev Aug 13, 2020
@skrakau skrakau deleted the add_phixref_summary branch May 31, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggabernet ggabernet ggabernet approved these changes

@d4straub d4straub Awaiting requested review from d4straub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skrakau @ggabernet