Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version number for v1.4.1 release #130

Merged
merged 2 commits into from
Dec 5, 2019
Merged

Bump version number for v1.4.1 release #130

merged 2 commits into from
Dec 5, 2019

Conversation

ewels
Copy link
Member

@ewels ewels commented Dec 4, 2019

Bumped version number ready for the v1.4.1 minor release

@ewels ewels requested review from phue and a team December 4, 2019 15:49
@phue
Copy link
Member

phue commented Dec 4, 2019

I think we might have another python problem here :

 ERROR ~ Error executing process > 'trim_galore (LowerStem_D2_single)'


Caused by:

  Process `trim_galore (LowerStem_D2_single)` terminated with an error exit status (1)


Command executed:

  trim_galore --cores 4 --fastqc --gzip  --clip_r1 8 --three_prime_clip_r1 8 LowerStem_D2_single.fastq

Command exit status:
  1

Command output:
  (empty)


Command error:
  Letting the (modified) Cutadapt deal with the Python version instead

  Parallel gzip (pigz) detected. Proceeding with multicore (de)compression using 4 cores
     >>> Now performing quality (cutoff '-q 20') and adapter trimming in a single pass for the adapter sequence: 'AGATCGGAAGAGC' from file LowerStem_D2_single.fastq <<< 

  ERROR: Running in parallel is not supported on Python 2

  Cutadapt terminated with exit signal: '256'.

  Terminating Trim Galore run, please check error message(s) to get an idea what went wrong...

@ewels
Copy link
Member Author

ewels commented Dec 4, 2019

Argh! So cutadapt needs python 3 and HISAT2 needs python 2?

@phue
Copy link
Member

phue commented Dec 4, 2019

Argh! So cutadapt needs python 3 and HISAT2 needs python 2?

seems like 😞

@apeltzer
Copy link
Member

apeltzer commented Dec 4, 2019

But that shouldn't be the case - its one of the tools running 2to3 so it should be running on python3 - see the bioconda build script for the recipe here!

@ewels
Copy link
Member Author

ewels commented Dec 5, 2019

Yes, but then the python 3 builds are skipped anyway. I already made an issue asking why: bioconda/bioconda-recipes#18911

I might try to prep a PR to enable py3k builds again and see what happens.

@apeltzer
Copy link
Member

apeltzer commented Dec 5, 2019

bioconda/bioconda-recipes#19100 once that is in, this should work again. Just need to use the latest hisat2 recipe then, which should be python3 compatible --> done 👍

@ewels
Copy link
Member Author

ewels commented Dec 5, 2019

HiSAT2 should now be py3k compatible on bioconda! 🎉

Added Python 3 back as a requirement here. This PR should be merged then we'll need another PR to test again.

@phue
Copy link
Member

phue commented Dec 5, 2019

Great stuff! MultiQC 1.8 should also work then?

@apeltzer
Copy link
Member

apeltzer commented Dec 5, 2019

Yes !

@ewels ewels merged commit da33e8e into nf-core:dev Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants