-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dsl2 port #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fastqc * picard/markduplicates * preseq/lcextrap * samtools/flagstat * samtools/index * samtools/stats * samtools/sort * trimgalore * multiqc
* bismark/genome_preparation * bismark/align * bismark/deduplicate * bismark/extract * bismark/report * bismark/summary TODO: write tests and add to nf-core/modules
* bwameth/align * bwameth/index TODO: write tests and add to nf-core/modules
* methyldackel/extract * methyldackel/mbias TODO: write tests and add to nf-core modules
TODO: write tests and add to nf-core/modules
TODO: write tests and add to nf-core/modules
this is inspired by the functionality in nf-core/nanoseq and nf-core/rnaseq The idea is to require a samplesheet to run the pipeline, which will allow for single/paired end auto-detection and mapping samples against different reference genomes. addresses #181
TODO: needs change in nf-core/test-datasets
baseDir is deprecated
* fastqc * picard/markduplicates * preseq/lcextrap * samtools/flagstat * samtools/index * samtools/stats * samtools/sort * trimgalore * multiqc
* bismark/genome_preparation * bismark/align * bismark/deduplicate * bismark/extract * bismark/report * bismark/summary TODO: write tests and add to nf-core/modules
* bwameth/align * bwameth/index TODO: write tests and add to nf-core/modules
* methyldackel/extract * methyldackel/mbias TODO: write tests and add to nf-core modules
TODO: write tests and add to nf-core/modules
TODO: write tests and add to nf-core/modules
this is inspired by the functionality in nf-core/nanoseq and nf-core/rnaseq The idea is to require a samplesheet to run the pipeline, which will allow for single/paired end auto-detection and mapping samples against different reference genomes. addresses #181
TODO: needs change in nf-core/test-datasets
Try to avoid the warning about having duplicate processes
Final (?!) updates to `dsl2` before merge
Update methylkit/extract module.
ewels
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #182 (now from a dedicated branch)
The pipeline now requires a sample sheet to be passed to the pipeline with
--input
:See an example here
The
genome
column is optional,--genome
continues to work as wellKnown issues:
workflow summary shows NAs-> (fixed by @ewels in Rewrite the schema summary log #206)-> (fixed in 0fd1614)MultiQC
report is missing some data-> (fixed in methylseq: add samplesheet for full-size tests test-datasets#232)-profile test_full
needs asamplesheet.csv