Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dsl2 port #199

Merged
merged 191 commits into from
Nov 3, 2022
Merged

dsl2 port #199

merged 191 commits into from
Nov 3, 2022

Conversation

phue
Copy link
Member

@phue phue commented Mar 24, 2021

Continuation of #182 (now from a dedicated branch)

⚠️ Breaking change:

The pipeline now requires a sample sheet to be passed to the pipeline with --input:

sample fastq_1 fastq_2 genome

See an example here

The genome column is optional, --genome continues to work as well

Known issues:

phue added 30 commits January 19, 2021 20:32
* fastqc
* picard/markduplicates
* preseq/lcextrap
* samtools/flagstat
* samtools/index
* samtools/stats
* samtools/sort
* trimgalore
* multiqc
* bismark/genome_preparation
* bismark/align
* bismark/deduplicate
* bismark/extract
* bismark/report
* bismark/summary

TODO: write tests and add to nf-core/modules
* bwameth/align
* bwameth/index

TODO: write tests and add to nf-core/modules
* methyldackel/extract
* methyldackel/mbias

TODO: write tests and add to nf-core modules
TODO: write tests and add to nf-core/modules
TODO: write tests and add to nf-core/modules
this is inspired by the functionality in nf-core/nanoseq and
nf-core/rnaseq
The idea is to require a samplesheet to run the pipeline, which will
allow for single/paired end auto-detection and mapping samples against
different reference genomes.

addresses #181
TODO: needs change in nf-core/test-datasets
baseDir is deprecated
* fastqc
* picard/markduplicates
* preseq/lcextrap
* samtools/flagstat
* samtools/index
* samtools/stats
* samtools/sort
* trimgalore
* multiqc
* bismark/genome_preparation
* bismark/align
* bismark/deduplicate
* bismark/extract
* bismark/report
* bismark/summary

TODO: write tests and add to nf-core/modules
* bwameth/align
* bwameth/index

TODO: write tests and add to nf-core/modules
* methyldackel/extract
* methyldackel/mbias

TODO: write tests and add to nf-core modules
TODO: write tests and add to nf-core/modules
TODO: write tests and add to nf-core/modules
this is inspired by the functionality in nf-core/nanoseq and
nf-core/rnaseq
The idea is to require a samplesheet to run the pipeline, which will
allow for single/paired end auto-detection and mapping samples against
different reference genomes.

addresses #181
TODO: needs change in nf-core/test-datasets
@ewels
Copy link
Member

ewels commented Nov 3, 2022

Let's do it! :shipit:

lightspeed

@ewels ewels merged commit 0544068 into dev Nov 3, 2022
@ewels ewels deleted the dsl2 branch November 3, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants