Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template sync #92

Merged
merged 20 commits into from
Apr 26, 2019
Merged

Template sync #92

merged 20 commits into from
Apr 26, 2019

Conversation

phue
Copy link
Member

@phue phue commented Apr 10, 2019

This should finally close #44

There were quite a few merge conflicts, so we should test it properly...

Most notable changes to match the features according to the template

  • added a helpMessage
  • added r-markdown as a dependency that is needed to render the output info html
  • removed deprecated installation.md as this information is now on the website
  • removed NGI logos and references as we now use nf-core logos only ( I hope this is OK @ewels )

@phue phue added the WIP Work in progress label Apr 11, 2019
@phue
Copy link
Member Author

phue commented Apr 13, 2019

There seems to be a small bug with the recent addition of bismark_hisat as an aligner option, that only occurs when there is more than one CPU available for the alignment step. Travis tests pass because this particular case is not covered.

I submitted FelixKrueger/Bismark#250 upstream that should fix the issue but we probably have to wait for a new bismark release before releasing this.

Edit: fixed with bismark v0.22.1

@phue phue removed the WIP Work in progress label Apr 14, 2019
@phue
Copy link
Member Author

phue commented Apr 14, 2019

Other than that, this should be fine for merging to dev (the bug already exists in the dev branch anyway)

We just need to bump the software version(s) before releasing 1.4

@phue phue requested a review from a team April 14, 2019 09:30
@phue
Copy link
Member Author

phue commented Apr 17, 2019

@ewels:
Would be nice to add the HiSAT indices (of the three-letter converted genomes) to the iGenomes bucket aswell.
I have no clue how these AWS things work, do you have any pointers for me? :)

@ewels
Copy link
Member

ewels commented Apr 21, 2019

Awesome! I'm away on leave now so don't have time to review sorry. Hopefully someone else can do so and merge though 👍

For AWS, it's a bit tricky as it's not very community-run yet. It's basically just me. In the past we've done it by someone else creating an AWS s3 bucket with all of the files organised in the correct directory structure, then I just run the sync command between the two buckets. Needs care though, so I'd recommend doing this when I'm back after the summer. Feel free to make an issue for it on https://github.com/ewels/AWS-iGenomes 🤔

Phil

@apeltzer
Copy link
Member

Can review after Easter - on holiday atm

@phue phue requested a review from apeltzer April 26, 2019 11:19
@apeltzer apeltzer merged commit 31bf8fa into nf-core:dev Apr 26, 2019
@phue phue deleted the template_merge branch April 29, 2019 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants