Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix custom config for multiqc #219

Merged
merged 3 commits into from
Mar 7, 2023
Merged

fix custom config for multiqc #219

merged 3 commits into from
Mar 7, 2023

Conversation

maxulysse
Copy link
Member

@maxulysse maxulysse commented Mar 3, 2023 •
edited by FranBonath
Loading

Not sure this actually ever worked.
Thanks to @FranBonath for spotting the issue

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/nanoseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

yuukiiwa and others added 3 commits February 15, 2023 11:24
@yuukiiwa
Merge pull request #216 from nf-core/update_3_1
8e65b61 
Bambu update, bug fixes, and template update
@christopher-hakkaart
Merge pull request #217 from nf-core/update_3_1
adc0832 
remove guppy
@maxulysse
fix custom config for multiqc
2b824f5 
Not sure this actually ever worked.
Thanks to @FranBonath for spotting the issue
@github-actions
Copy link

github-actions bot commented Mar 7, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 2b824f5

+| ✅ 156 tests passed       |+
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: '3.0.0'
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-03-03 14:39:38

@yuukiiwa yuukiiwa self-requested a review March 7, 2023 13:17
yuukiiwa
yuukiiwa approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@yuukiiwa yuukiiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @maxulysse!

@yuukiiwa yuukiiwa changed the base branch from dev to update_3_1 March 7, 2023 13:18
@yuukiiwa yuukiiwa merged commit 75cc128 into update_3_1 Mar 7, 2023
@yuukiiwa yuukiiwa deleted the maxulysse-patch-1 branch March 10, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuukiiwa yuukiiwa yuukiiwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxulysse @yuukiiwa @christopher-hakkaart