Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge template 2.13 #71

Merged
merged 10 commits into from
Apr 17, 2024

Conversation

christopher-mohr
Copy link
Collaborator

@christopher-mohr christopher-mohr commented Apr 16, 2024

Merge the most recent template.

My suggestion would be to make the column "RCC_FILE_NAME" mandatory as well to avoid the need for manipulating the provided samplesheet. Would anything speak against it?

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/nanostring branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@christopher-mohr christopher-mohr added the WIP Work in progress label Apr 16, 2024
Copy link

github-actions bot commented Apr 16, 2024

nf-core lint overall result: Passed ✅

Posted for pipeline commit 7ac92a7

+| ✅ 174 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-04-17 13:56:01

@apeltzer
Copy link
Member

No objections against making that mandatory either.

@christopher-mohr christopher-mohr removed the WIP Work in progress label Apr 17, 2024
@christopher-mohr christopher-mohr merged commit 1caa124 into nf-core:dev Apr 17, 2024
4 checks passed
@christopher-mohr christopher-mohr deleted the merge_template_2_13 branch April 17, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants