Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastify pangenome generation #36

Closed
subwaystation opened this issue Jan 26, 2021 · 1 comment · Fixed by #44
Closed

fastify pangenome generation #36

subwaystation opened this issue Jan 26, 2021 · 1 comment · Fixed by #44
Labels
enhancement Improvement for existing functionality

Comments

@subwaystation
Copy link
Collaborator

subwaystation commented Jan 26, 2021

nf-core/pangenome feature request

Hi there!

Describe the solution you'd like

Recently, there has been a major pggb update pangenome/pggb#46. It improves performance significantly. And it changes a little bit the command line API.

  • Update Dockerfile
  • Update the input parameters
  • Update processes to work with the adjusted input parameters
  • Update file namings
  • Update tests
  • Add a new larger test making use of the yeast pangenome
@subwaystation subwaystation added the enhancement Improvement for existing functionality label Jan 26, 2021
subwaystation added a commit that referenced this issue Feb 16, 2023
@github-actions
Copy link

Markdown linting is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install markdownlint-cli
  • Fix the markdown errors
    • Automatically: markdownlint . --config .github/markdownlint.yml --fix
    • Manually resolve anything left from markdownlint . --config .github/markdownlint.yml

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up markdownlint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant