Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use FROM ghcr.io/pangenome/pggb:latest #4

Merged
merged 6 commits into from
Nov 21, 2020
Merged

Conversation

heuermh
Copy link
Contributor

@heuermh heuermh commented Nov 12, 2020

Work in progress

@Zethson Zethson marked this pull request as ready for review November 13, 2020 17:36
@heuermh
Copy link
Contributor Author

heuermh commented Nov 13, 2020

Thanks for the changes! Unfortunately the path is still not set correctly

$ docker build --no-cache . -t nfcore/pangenome:dev
...
Successfully tagged nfcore/pangenome:dev

(base) nf-core-pangenome docker-alt
$ nextflow run main.nf -profile test,docker
...
Command error:
  /usr/bin/env: 'python': Permission denied

$ docker run -it nfcore/pangenome:dev /bin/bash
root@c31c6b6a916c:/# which python
root@c31c6b6a916c:/# env | grep PATH
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
root@c31c6b6a916c:/# exit

I think I have a fix though, moving the /etc/profile line later, will push another commit.

@heuermh
Copy link
Contributor Author

heuermh commented Nov 13, 2020

With commit 1f43d29 the container path is correct and the workflow (as it is) makes it farther

(base) nf-core-pangenome docker-alt!
$ docker run -it nfcore/pangenome:dev /bin/bash
root@ae9d7ccef4e7:/# which python
/root/miniconda3/bin/python
root@ae9d7ccef4e7:/# env | grep PATH
PATH=/opt/conda/envs/nf-core-pangenome-1.0dev/bin:/root/miniconda3/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
root@ae9d7ccef4e7:/# exit

(base) nf-core-pangenome docker-alt!
$ nextflow run main.nf -profile test,docker
...
Command error:
  .command.sh: line 4: fastqc: command not found

which is to be expected, as fastqc will not be used in this workflow.

@Zethson
Copy link
Member

Zethson commented Nov 21, 2020

@heuermh Sorry, i was not following this PR and therefore got no notifications.
I only tested Conda and not Python, but I'm glad to see that you have it figured out.

So this PR is ready I guess?

We can add the dependencies that we need as we go.

@heuermh
Copy link
Contributor Author

heuermh commented Nov 21, 2020

Yes, this is ready for review, if we prefer it over #2

@Zethson
Copy link
Member

Zethson commented Nov 21, 2020

I would say so.

LGTM

@Zethson Zethson merged commit 5acbff2 into nf-core:dev Nov 21, 2020
@heuermh
Copy link
Contributor Author

heuermh commented Nov 22, 2020

Thank you, @Zethson

@heuermh heuermh deleted the docker-alt branch November 22, 2020 04:25
Zethson pushed a commit that referenced this pull request Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants