Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to pixelator 0.16.2 #84

Merged
merged 11 commits into from
Mar 21, 2024
Merged

Update to pixelator 0.16.2 #84

merged 11 commits into from
Mar 21, 2024

Conversation

johandahlberg
Copy link
Collaborator

@johandahlberg johandahlberg commented Mar 20, 2024 •
edited
Loading

This updates nf-core-pixelator to use pixelator 0.16.2.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/pixelator branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 20, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 12c1383

+| ✅ 180 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-03-21 09:35:12

@johandahlberg johandahlberg force-pushed the EXE-1100-prepping-for-pixelator-0.16 branch from 9526adf to 56c8b20 Compare March 20, 2024 15:45
@johandahlberg johandahlberg force-pushed the EXE-1100-prepping-for-pixelator-0.16 branch from 56c8b20 to ab7ae89 Compare March 20, 2024 15:49
johandahlberg
johandahlberg commented Mar 21, 2024
View reviewed changes
assets/nf-params.yml Outdated Show resolved Hide resolved
@johandahlberg johandahlberg marked this pull request as ready for review March 21, 2024 08:40
fbdtemme
fbdtemme reviewed Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@fbdtemme fbdtemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the metromap:
https://www.figma.com/file/TKFwW6YDqTZ4nFNQdfesaf/nf-core-pixelator-Metromap?type=design&node-id=507-75&mode=design&t=5u0Wy28XbsyBUvrv-4

CHANGELOG.md Show resolved Hide resolved
@johandahlberg johandahlberg merged commit 548472f into nf-core:dev Mar 21, 2024
4 checks passed
@fbdtemme fbdtemme mentioned this pull request Mar 26, 2024
Merged
11 tasks
@fbdtemme fbdtemme deleted the EXE-1100-prepping-for-pixelator-0.16 branch May 29, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbdtemme fbdtemme fbdtemme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johandahlberg @fbdtemme