Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Add mimetype to input parameter in schema #45

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Add mimetype to input parameter in schema #45

merged 1 commit into from
Aug 12, 2022

Conversation

drpatelh
Copy link
Member

@drpatelh drpatelh commented Jun 24, 2022 •
edited
Loading

This allows using the pipeline with Datasets on Nextflow Tower. We need to be explicit about the mimetype so the Dataset is rendered when launching the pipeline.

@github-actions
Copy link

github-actions bot commented Jun 24, 2022 •
edited
Loading

nf-core lint overall result: Failed ❌

Posted for pipeline commit 4da214c

+| ✅ 140 tests passed       |+
#| ❔   3 tests were ignored |#
-| ❌   5 tests failed       |-

❌ Test failures:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-06-24 10:10:01

@drpatelh drpatelh requested review from jpfeuffer and ypriverol June 27, 2022 13:21
@ypriverol
Copy link
Member

@drpatelh should I merge this into dev or close the PR. The linting is failing.

@jpfeuffer
Copy link
Collaborator

You can merge it. The linting is because if the tools version. See other pr

@ypriverol
Copy link
Member

All tests should pass for me to be able to merged

ypriverol added a commit that referenced this pull request Aug 4, 2022
@ypriverol
Merge pull request #45 from ypriverol/dev
b13f39f 
improvements
@jpfeuffer jpfeuffer merged commit da03571 into nf-core:dev Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ypriverol ypriverol ypriverol approved these changes

@jpfeuffer jpfeuffer jpfeuffer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drpatelh @ypriverol @jpfeuffer