Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Merging-template #70

Merged
merged 5 commits into from
Mar 7, 2023
Merged

Merging-template #70

merged 5 commits into from
Mar 7, 2023

Conversation

jpfeuffer
Copy link
Collaborator

@jpfeuffer jpfeuffer commented Mar 7, 2023 •
edited
Loading

Closes #66

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/quantms branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Python linting (black) is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install black: pip install black
  • Fix formatting errors in your pipeline: black .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up Black in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

@fabianegli
Copy link
Contributor

fabianegli commented Mar 7, 2023 •
edited
Loading

If this the same as #66 - and I think it is - #66 could be closed.

@jpfeuffer jpfeuffer mentioned this pull request Mar 7, 2023
Merged
9 tasks
@jpfeuffer
Copy link
Collaborator Author

tests failing but unrelated to the template merge.

@jpfeuffer jpfeuffer merged commit 7ff7a72 into dev Mar 7, 2023
@jpfeuffer jpfeuffer deleted the merging-template branch March 7, 2023 15:08
@github-actions
Copy link

github-actions bot commented Mar 7, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 0ec0a41

+| ✅ 155 tests passed       |+
#| ❔   3 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-03-07 14:35:15

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpfeuffer @fabianegli @nf-core-bot