Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CADD for indels #143

Closed
jemten opened this issue Mar 22, 2022 · 5 comments · Fixed by #325
Closed

Add CADD for indels #143

jemten opened this issue Mar 22, 2022 · 5 comments · Fixed by #325
Assignees
Labels
enhancement Improvement for existing functionality

Comments

@jemten
Copy link
Collaborator

jemten commented Mar 22, 2022

The team behind CADD provide precomputed CADD scores for SNVs. The CADD scores for Indels needs to be calculated dynamically. Depending on how komplex the workflow becomes this might be splitted out into it's own subworkflow under SNV/INDEL annotation.

@jemten jemten added the enhancement Improvement for existing functionality label Mar 22, 2022
@jemten jemten self-assigned this Mar 22, 2022
@maxulysse
Copy link
Member

We're using the CADD plugin in VEP in the 2.7.1 sarek, haven't added that possibilities to the vep modules yet, since it's a bit messy: https://github.com/nf-core/sarek/blob/68b9930a74962f3c42eee71f51e6dd2646269199/main.nf#L3695
(actually it's the genesplicer one that is messy).
I'd love to see your ideas about that

@jemten
Copy link
Collaborator Author

jemten commented Mar 22, 2022

@maxulysse
Nice! Are you using the pre-computed indel scores or are you calculating them yourself?

@maxulysse
Copy link
Member

Using the precomputed ones

@ramprasadn
Copy link
Collaborator

nf-core/modules#3216 I have attempted to CADD to nf-core/modules. Let me know what you guys think!

@ramprasadn ramprasadn linked a pull request Apr 3, 2023 that will close this issue
11 tasks
@jemten jemten added this to the Release candidate 2 milestone Apr 5, 2023
@jemten
Copy link
Collaborator Author

jemten commented May 3, 2023

done

@jemten jemten closed this as completed May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants