Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate small indels with CADD scores #325

Merged
merged 16 commits into from
Apr 25, 2023

Conversation

ramprasadn
Copy link
Collaborator

@ramprasadn ramprasadn commented Apr 3, 2023

PR checklist

This PR adds the functionality to annotate small indel with CADD scores.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/raredisease branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR> -stub).
  • Ensure the test suite passes (nextflow run . -profile test_one_sample,docker --outdir <OUTDIR> -stub).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@ramprasadn ramprasadn linked an issue Apr 3, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 3926a7c

+| ✅ 150 tests passed       |+
#| ❔   7 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: '1.0.0'
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting_comment.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-04-25 09:21:37

@ramprasadn ramprasadn marked this pull request as ready for review April 4, 2023 22:28
@ramprasadn ramprasadn changed the title Cadd indels Annotate small indels with CADD scores Apr 4, 2023
Copy link
Collaborator

@jemten jemten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be nice to get CADD running :)
Some comments

@@ -0,0 +1 @@
##INFO=<ID=CADD,Number=1,Type=Float,Description="The CADD relative score for this alternative.">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
##INFO=<ID=CADD,Number=1,Type=Float,Description="The CADD relative score for this alternative.">
##INFO=<ID=CADD,Number=1,Type=Float,Description="PHRED-like scaled CADD score">

@@ -140,6 +141,9 @@ workflow RAREDISEASE {
}

// Initialize all file channels including unprocessed vcf, bed and tab files
ch_cadd_header = Channel.fromPath("$projectDir/assets/cadd_to_vcf_header_-1.0-.txt", checkIfExists: true).collect()
ch_cadd_scores = params.cadd_annotation ? Channel.fromPath(params.cadd_annotation).collect()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ch_cadd_scores = params.cadd_annotation ? Channel.fromPath(params.cadd_annotation).collect()
ch_cadd_annotations = params.cadd_annotation ? Channel.fromPath(params.cadd_annotation).collect()

The scores haven't been computed yet

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe ch_cadd_resources is better? You decide :)

@@ -401,6 +405,8 @@ workflow RAREDISEASE {
if (!params.skip_mt_analysis) {
ANALYSE_MT (
ch_mapped.bam_bai,
ch_cadd_header,
ch_cadd_scores,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ch_cadd_scores,
ch_cadd_annotations,

@@ -448,6 +454,8 @@ workflow RAREDISEASE {
ANNOTATE_SNVS (
ch_vcf,
params.analysis_type,
ch_cadd_header,
ch_cadd_scores,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ch_cadd_scores,
ch_cadd_annotations,

ch_vcf // channel: [mandatory] [ val(meta), path(vcfs) ]
ch_index // channel: [mandatory] [ val(meta), path(tbis) ]
ch_header // channel: [mandatory] [ path(txt) ]
ch_cadd_scores // channel: [mandatory] [ path(dir) ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ch_cadd_scores // channel: [mandatory] [ path(dir) ]
ch_cadd_annotations // channel: [mandatory] [ path(dir) ]

Comment on lines 92 to 99
GATK4_SELECTVARIANTS.out.vcf
.combine(ANNOTATE_CADD.out.vcf.ifEmpty("null"))
.branch { it ->
selvar: it[2].equals("null")
return [it[0], it[1]]
cadd: !(it[2].equals("null"))
return [it[2], it[3]]
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain this code a bit more

@ramprasadn ramprasadn requested a review from jemten April 25, 2023 09:40
Copy link
Collaborator

@jemten jemten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ramprasadn ramprasadn merged commit 37d5509 into nf-core:devplaceholder Apr 25, 2023
@ramprasadn ramprasadn deleted the cadd_indels branch April 25, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CADD for indels
2 participants