Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch release v1.1.1 #388

Merged
merged 5 commits into from
Jul 26, 2023
Merged

Patch release v1.1.1 #388

merged 5 commits into from
Jul 26, 2023

Conversation

ramprasadn
Copy link
Collaborator

@ramprasadn ramprasadn commented Jul 25, 2023 •
edited
Loading

Description

  • Configures bcftools merge to generate compressed vcf files.
  • Fixes errors thrown by bcftools concat due to sample names in input vcf files not being in same order.
    • GATK's MergeVcfs can handle such differences hence, the switch. However, GATK complains about spaces in the INFO columns so I have added a small groovy function to create a reformatted vcf file.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/raredisease branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Ensure the test suite passes (nextflow run . -profile test_one_sample,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Jul 25, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 5c89cd1

+| ✅ 153 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.1.1
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-07-26 08:39:40

@ramprasadn ramprasadn marked this pull request as ready for review July 25, 2023 16:50
asp8200
asp8200 reviewed Jul 26, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
asp8200
asp8200 reviewed Jul 26, 2023
View reviewed changes
workflows/raredisease.nf Outdated Show resolved Hide resolved
asp8200
asp8200 approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@asp8200 asp8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jfy133
jfy133 approved these changes Jul 26, 2023
View reviewed changes
CHANGELOG.md Outdated
@@ -3,6 +3,12 @@
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## v1.1.1 - Abu (Patch) [xxxx-xx-xx]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set date!

Copy link
Collaborator Author

@ramprasadn ramprasadn Jul 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! 😄

@ramprasadn
Copy link
Collaborator Author

Thanks for the review @asp8200 and @jfy133 👍🏻

@ramprasadn ramprasadn merged commit c371602 into nf-core:master Jul 26, 2023
@ramprasadn ramprasadn deleted the patch branch August 1, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asp8200 asp8200 asp8200 approved these changes

@jfy133 jfy133 jfy133 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramprasadn @jfy133 @asp8200