Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sentieon/dnascope from nf-core/modules #406

Merged
merged 7 commits into from
Aug 18, 2023
Merged

Add sentieon/dnascope from nf-core/modules #406

merged 7 commits into from
Aug 18, 2023

Conversation

ramprasadn
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/raredisease branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Ensure the test suite passes (nextflow run . -profile test_one_sample,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Aug 17, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 2f47cd1

+| ✅ 151 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-08-17 16:01:46

@ramprasadn ramprasadn marked this pull request as ready for review August 17, 2023 18:49
@ramprasadn ramprasadn requested a review from asp8200 August 18, 2023 08:34
asp8200
asp8200 reviewed Aug 18, 2023
View reviewed changes
workflows/raredisease.nf
@@ -234,8 +234,8 @@ workflow RAREDISEASE {
: Channel.empty()
ch_intervals_y = params.intervals_y ? Channel.fromPath(params.intervals_y).collect()
: Channel.empty()
ch_ml_model = params.variant_caller.equals("sentieon") ? Channel.fromPath(params.ml_model).collect()
: Channel.value([])
ch_ml_model = params.variant_caller.equals("sentieon") ? Channel.fromPath(params.ml_model).map {it -> [[id:it[0].simpleName], it]}.collect()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, when using params.variant_caller.equals("sentieon") it kind of indicates that the raredisease-pipeline is designed to only use one variant-caller per run of the pipeline - is that correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is correct 😄

asp8200
asp8200 approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@asp8200 asp8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramprasadn ramprasadn merged commit e58c7ef into nf-core:dev Aug 18, 2023
@ramprasadn ramprasadn deleted the dnascope branch August 22, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asp8200 asp8200 asp8200 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramprasadn @asp8200