Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rhocall viz #512

Merged
merged 8 commits into from
Feb 8, 2024
Merged

Add rhocall viz #512

merged 8 commits into from
Feb 8, 2024

Conversation

ramprasadn
Copy link
Collaborator

PR checklist

Addresses #496

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/raredisease branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Ensure the test suite passes (nextflow run . -profile test_one_sample,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 8178f32

+| ✅ 182 tests passed       |+
#| ❔   5 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in WorkflowRaredisease.groovy: Optionally add in-text citation tools to this list.

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-raredisease_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-raredisease_logo_dark.png

✅ Tests passed:

Run details

  • nf-core/tools version 2.12.1
  • Run at 2024-02-07 14:26:01

@ramprasadn ramprasadn marked this pull request as ready for review February 6, 2024 13:17
@Lucpen
Copy link
Contributor

Lucpen commented Feb 8, 2024

Very nice, just one tiny thing, it would be good to add in docs/usage what files are necessary to run this module

@ramprasadn
Copy link
Collaborator Author

No additional files are necessary to run this module @Lucpen. All files required to run this modules are generated during the run by the pipeline.

@Lucpen
Copy link
Contributor

Lucpen commented Feb 8, 2024

Perfect!

Lucpen
Lucpen approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@Lucpen Lucpen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ramprasadn ramprasadn merged commit c2237fe into nf-core:dev Feb 8, 2024
6 checks passed
@ramprasadn ramprasadn deleted the rhocall_viz branch February 8, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lucpen Lucpen Lucpen approved these changes

@jemten jemten Awaiting requested review from jemten

@rannick rannick Awaiting requested review from rannick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramprasadn @Lucpen