Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update filenames #395

Merged
merged 18 commits into from
Sep 13, 2023
Merged

Update filenames #395

merged 18 commits into from
Sep 13, 2023

Conversation

rannick
Copy link
Collaborator

@rannick rannick commented Sep 6, 2023

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnafusion branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Sep 6, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 5ee433c

+| ✅ 158 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-09-13 14:36:14

@rannick rannick self-assigned this Sep 8, 2023
@rannick rannick requested a review from fevac September 8, 2023 08:49
fevac
fevac requested changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@fevac fevac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🌟 can we test with the minimum dataset?

CHANGELOG.md Outdated Show resolved Hide resolved
conf/modules.config Show resolved Hide resolved
fevac
fevac approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@fevac fevac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 💯

@rannick rannick merged commit 6282473 into dev Sep 13, 2023
6 checks passed
@rannick rannick deleted the update_filenames branch September 13, 2023 14:49
@rannick rannick mentioned this pull request Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fevac fevac fevac approved these changes

Assignees

@rannick rannick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rannick @fevac