Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nf-test to FUSIONREPORT_DETECT #577

Merged
merged 7 commits into from
Dec 9, 2024
Merged

Add nf-test to FUSIONREPORT_DETECT #577

merged 7 commits into from
Dec 9, 2024

Conversation

atrigila
Copy link

@atrigila atrigila commented Dec 6, 2024 •
edited
Loading

Closes #561

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnafusion branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@atrigila atrigila self-assigned this Dec 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅

Posted for pipeline commit d7a06ea

+| ✅ 222 tests passed       |+
#| ❔   2 tests were ignored |#

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-12-09 13:37:45

nschcolnicov
nschcolnicov reviewed Dec 9, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
nschcolnicov
nschcolnicov approved these changes Dec 9, 2024
View reviewed changes
Copy link

@nschcolnicov nschcolnicov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please update PR number in CHANGELOG

alanmmobbs93
alanmmobbs93 approved these changes Dec 9, 2024
View reviewed changes
Copy link

@alanmmobbs93 alanmmobbs93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! But is it a draft for some particular reason?

@atrigila atrigila marked this pull request as ready for review December 9, 2024 13:07
@atrigila atrigila merged commit cc5d4b9 into nf-core:dev Dec 9, 2024
7 checks passed
@atrigila atrigila deleted the fusionreport_detect branch December 9, 2024 13:48
@rannick rannick mentioned this pull request Dec 10, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschcolnicov nschcolnicov nschcolnicov approved these changes

@alanmmobbs93 alanmmobbs93 alanmmobbs93 approved these changes

Assignees

@atrigila atrigila

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atrigila @alanmmobbs93 @nschcolnicov