Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add singularity containers #588

Merged
merged 16 commits into from
Dec 19, 2024
Merged

Add singularity containers #588

merged 16 commits into from
Dec 19, 2024

Conversation

rannick
Copy link
Collaborator

@rannick rannick commented Dec 17, 2024

Singularity support was dropped temporarily for singularity containers when wave was use. Temporarily reintroducing docker containers until oras support is cleared out for wave containers

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnafusion branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@rannick rannick self-assigned this Dec 17, 2024
@rannick rannick changed the base branch from master to dev December 17, 2024 14:23
@nf-core nf-core deleted a comment from github-actions bot Dec 17, 2024
Copy link

github-actions bot commented Dec 17, 2024

nf-core pipelines lint overall result: Passed ✅

Posted for pipeline commit 27b3f8b

+| ✅ 222 tests passed       |+
#| ❔   2 tests were ignored |#

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-12-19 11:50:02

@nf-core-bot
Copy link
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.0.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

modules/local/fusioninspector/main.nf Outdated Show resolved Hide resolved
modules/local/fusioninspector/environment.yml Outdated Show resolved Hide resolved
modules/local/starfusion/build/environment.yml Outdated Show resolved Hide resolved
modules/local/starfusion/build/main.nf Outdated Show resolved Hide resolved
modules/local/starfusion/detect/environment.yml Outdated Show resolved Hide resolved
modules/local/fusioncatcher/detect/main.nf Show resolved Hide resolved
@rannick
Copy link
Collaborator Author

rannick commented Dec 19, 2024

To document: it seems the docker wave container does not execute STAR properly, it might not be an issue, but let's keep that in mind

@rannick rannick merged commit 1ede9b4 into dev Dec 19, 2024
10 checks passed
@rannick rannick deleted the add_singularity_containers branch December 19, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants