Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate CAT_ADDITIONAL_FASTA module to nf-core/modules #1162

Closed
adamrtalbot opened this issue Jan 8, 2024 · 3 comments · Fixed by #1216
Closed

Migrate CAT_ADDITIONAL_FASTA module to nf-core/modules #1162

adamrtalbot opened this issue Jan 8, 2024 · 3 comments · Fixed by #1216
Labels
enhancement nf-core/modules
Milestone
nf-test

Comments

@adamrtalbot
Copy link
Contributor

adamrtalbot commented Jan 8, 2024 •
edited
Loading

Description of feature

Replace local CAT_ADDITIONAL_FASTA module with nf-core/modules version.
@adamrtalbot adamrtalbot added this to the nf-test milestone Jan 8, 2024
@adamrtalbot adamrtalbot mentioned this issue Jan 8, 2024
Closed
16 tasks
@pinin4fjords
Copy link
Member

This module has been added to nf-core: https://github.com/nf-core/modules/tree/master/modules/nf-core/custom/catadditionalfasta, and has tests.

Only action will be to use this module in rnaseq

@adamrtalbot adamrtalbot changed the title Add nf-test to CAT_ADDITIONAL_FASTA module Migrate CAT_ADDITIONAL_FASTA module to nf-core/modules Jan 29, 2024
@adamrtalbot
Copy link
Contributor Author

nice, updated ticket to reflect change.

@pinin4fjords pinin4fjords mentioned this issue Feb 16, 2024
Merged
11 tasks
@pinin4fjords pinin4fjords linked a pull request Feb 16, 2024 that will close this issue
Delocalise catadditionalfasta #1216
Merged
11 tasks
@pinin4fjords
Copy link
Member

solved in #1216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement nf-core/modules
Projects
None yet
Milestone
nf-test
Development

Successfully merging a pull request may close this issue.

Delocalise catadditionalfasta nf-core/rnaseq
2 participants
@pinin4fjords @adamrtalbot