Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministic mapping for STAR aligner #396

Closed
olgabot opened this issue Mar 12, 2020 · 3 comments
Closed

Deterministic mapping for STAR aligner #396

olgabot opened this issue Mar 12, 2020 · 3 comments
Milestone

Comments

@olgabot
Copy link
Contributor

olgabot commented Mar 12, 2020

Related from .. a while ago: https://github.com/czbiohub/reflow-workflows/issues/23

Basically, one STAR run to the next is not equal, because multimapping reads are randomly assigned based based on the random seed. If we want the nf-core/rnaseq pipeline to be truly reproducible, should we fix the random seed to e.g. --runRNGseed 0, and maybe expose this as a parameter?

@drpatelh drpatelh added this to the 1.5 milestone Aug 18, 2020
@drpatelh
Copy link
Member

Added --runRNGseed 0 6d3e516 to the STAR command here. It makes sense to hard code this for the sake of reproducibility 👍

"will vary from run to run, unless only one thread is used and the seed is kept constant." - although the docs suggest that one thread has to be used too which is very unlikely. Anyway, one aspect is fixed now 😅

@apeltzer
Copy link
Member

Maybe my non-native english is in the way here: Doesn't this mean that it will not be deterministic if you set/hardcode it to --runRNGseed 0 and run the process with > 1 thread?

@drpatelh
Copy link
Member

Yep. That's my interpretation too. So adding the parameter above won't make a difference unless you use one thread to perform the alignments. But I think having it won't do any harm if our interpretation isn't correct either 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants