Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update subway map #912

Merged
merged 4 commits into from
Dec 20, 2022
Merged

update subway map #912

merged 4 commits into from
Dec 20, 2022

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Dec 20, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit a5e14fb

+| ✅ 154 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2022-12-20 16:00:08

jfy133
jfy133 reviewed Dec 20, 2022
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, but

image

Is getting very cramped now, what about angleing at 45 degrees? Like in the Paris line map: https://www.paris-metro-map.info/wp-content/uploads/Paris-metro-line-8-map.png

(guess who was travelling throug Paris yesterday ;))

@maxulysse
Copy link
Member Author

Looks OK, but

image

Is getting very cramped now, what about angleing at 45 degrees? Like in the Paris line map: https://www.paris-metro-map.info/wp-content/uploads/Paris-metro-line-8-map.png

(guess who was travelling throug Paris yesterday ;))

I was thinking the same

@maxulysse maxulysse requested a review from jfy133 December 20, 2022 14:05
@maxulysse
Copy link
Member Author

fix #906

jfy133
jfy133 reviewed Dec 20, 2022
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep them all the same angle (so left to right, bottom to top - i.e. like the top line) but alternating above and below the line is fine

@maxulysse
Copy link
Member Author

I would keep them all the same angle (so left to right, bottom to top - i.e. like the top line) but alternating above and below the line is fine

Went into another direction and extended the map in the end

@drpatelh drpatelh mentioned this pull request Dec 20, 2022
Closed
drpatelh
drpatelh approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@drpatelh drpatelh merged commit 0d4aa41 into nf-core:dev Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133 jfy133 left review comments

@drpatelh drpatelh drpatelh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxulysse @jfy133 @drpatelh