Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add default to outdir as it was in schema #108

Merged
merged 3 commits into from
Jun 10, 2022
Merged

add default to outdir as it was in schema #108

merged 3 commits into from
Jun 10, 2022

Conversation

fmalmeida
Copy link
Contributor

params.outdir had a default in schema but not in nextflow.config, thus was raising error when user did not specify it.

@fmalmeida
add default to outdir as it was in schema
e53fd85 
`params.outdir` had a default in schema but not in `nextflow.config`, thus was raising error when user did not specify it.
@github-actions
Copy link

github-actions bot commented Jun 10, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 2769109

+| ✅ 147 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: '2.0.0'
  • readme - README did not have a Nextflow minimum version badge.

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-06-10 11:42:52

@apeltzer
Copy link
Member

We need to update this in schema.json then instead...

@apeltzer apeltzer merged commit 2665d7c into dev Jun 10, 2022
@apeltzer apeltzer deleted the fmalmeida-outdir-default branch June 10, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmalmeida @apeltzer