Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes full tests with 10x references #109

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Fixes full tests with 10x references #109

merged 1 commit into from
Jun 10, 2022

Conversation

apeltzer
Copy link
Member

Fix tests with 10X references

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/scrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Fix tests with 10X references
@apeltzer apeltzer requested a review from ggabernet June 10, 2022 12:01
@github-actions
Copy link

github-actions bot commented Jun 10, 2022

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 1f87601

+| ✅ 147 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: '2.0.0'
  • readme - README did not have a Nextflow minimum version badge.

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-06-10 12:02:15

@apeltzer apeltzer mentioned this pull request Jun 10, 2022
@apeltzer apeltzer merged commit 7f9d04a into dev Jun 10, 2022
@apeltzer apeltzer deleted the fix-full-tests branch June 10, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant