Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove public_aws_ecr profile #242

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

adamrtalbot
Copy link
Contributor

Remove public_aws_ecr profile

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/scrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Jun 19, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 58996c4

+| ✅ 157 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • system_exit - System.exit in WorkflowScrnaseq.groovy: System.exit(1) [line 18]

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-06-27 08:28:40

@adamrtalbot
Copy link
Contributor Author

@nf-core-bot fix linting

@adamrtalbot adamrtalbot merged commit a52eb49 into nf-core:dev Jun 27, 2023
@adamrtalbot adamrtalbot deleted the remove-public-aws-ecr-profile branch June 27, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants