Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSL2 version with working alevin workflow #55

Merged
merged 27 commits into from
Apr 19, 2021
Merged

Conversation

KevinMenden
Copy link
Contributor

I have started with the DSL2 version combining the feat-dsl2 and the current dev branch.
Made a new branch now because I'm not sure which features of feat-dsl2 we might want to keep.

The structure is similar to the viralrecon pipeline. Local and nf-core modules are stored in the modules dir.
Similarly, subworkflows are stored in the subworkflows directory.
Finally we have a workflows directories which stores the different pipeline versions. So we would have one workflow for STARsolo, one for kallisto+bustools and one for alevin. Keeping them separated like this makes it easy to work on one of them without changing (or breaking) another workflow.

I've started with the alevin workflow now, which is basically functional and runs through. I will improve this a bit and clean up some scripts further, but made this PR so that we have a structure to work on.

@github-actions
Copy link

github-actions bot commented Apr 19, 2021

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit fa8009f

+| ✅ 124 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗  11 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: environment.yml
  • files_exist - File not found: Dockerfile
  • nextflow_config - Config manifest.version should end in dev: '1.1.0'
  • actions_awsfulltest - .github/workflows/awsfulltest.yml should test full datasets, not -profile test
  • pipeline_todos - TODO string in README.md: Write a 1-2 sentence summary of what data the pipeline is for and what it does
  • pipeline_todos - TODO string in README.md: Fill in short bullet-pointed list of default steps of pipeline
  • pipeline_todos - TODO string in README.md: If applicable, make list of people who have also contributed
  • pipeline_todos - TODO string in test_full.config: Specify the paths to your full test data ( on nf-core/test-datasets or directly in repositories, e.g. SRA)
  • pipeline_todos - TODO string in test_full.config: Give any required params for the test so that command line flags are not needed
  • pipeline_todos - TODO string in awstest.yml: You can customise CI pipeline run tests as required
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required

❔ Tests ignored:

  • conda_env_yaml - No environment.yml file found - skipping conda_env_yaml test
  • conda_dockerfile - No environment.yml / Dockerfile file found - skipping conda_dockerfile test

✅ Tests passed:

Run details

  • nf-core/tools version 1.13.3
  • Run at 2021-04-19 12:02:17

@KevinMenden
Copy link
Contributor Author

The STARsolo "pipeline" is now also implemented, as it consists basically of only two processes currently.

However, this is only tested with some 10X data, and STAR can also handle SmartSeq data. So we need some clever handling of all these different technologies...

@KevinMenden KevinMenden merged commit 5e86a46 into nf-core:dsl2 Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants