Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge template update v2.1 #74

Merged
merged 20 commits into from
Oct 29, 2021
Merged

Conversation

ggabernet
Copy link
Member

@ggabernet ggabernet commented Oct 29, 2021

Update template to v2.1

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/scrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Oct 29, 2021

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 4a1b964

+| ✅ 137 tests passed       |+
!| ❗  14 tests had warnings |!

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version mentioned in Quick Start section.
  • pipeline_todos - TODO string in README.md: Write a 1-2 sentence summary of what data the pipeline is for and what it does
  • pipeline_todos - TODO string in README.md: Add full-sized test dataset and amend the paragraph below if applicable
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release
  • pipeline_todos - TODO string in test_full.config: Specify the paths to your full test data ( on nf-core/test-datasets or directly in repositories, e.g. SRA)
  • pipeline_todos - TODO string in test_full.config: Give any required params for the test so that command line flags are not needed
  • pipeline_todos - TODO string in scrnaseq.nf: Add all file path parameters for the pipeline to the list below
  • pipeline_todos - TODO string in check_samplesheet.py: Update the check_samplesheet function
  • pipeline_todos - TODO string in check_samplesheet.py: Update the column names for the input samplesheet
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • schema_description - Ungrouped param in schema: skip_multiqc
  • schema_description - Ungrouped param in schema: seq_center
  • schema_description - No description provided in schema for parameter: protocol
  • schema_description - No description provided in schema for parameter: star_ignore_sjdbgtf

✅ Tests passed:

Run details

  • nf-core/tools version 2.1
  • Run at 2021-10-29 13:52:16

@ggabernet ggabernet merged commit dad29ac into nf-core:dsl2 Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants