Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KrakenUniq read extraction #474

Closed
SannaAb opened this issue Apr 17, 2024 · 4 comments · Fixed by nf-core/modules#5567
Closed

KrakenUniq read extraction #474

SannaAb opened this issue Apr 17, 2024 · 4 comments · Fixed by nf-core/modules#5567
Assignees
Labels
bug Something isn't working
Milestone

Comments

@SannaAb
Copy link

SannaAb commented Apr 17, 2024

Description of the bug

Hi,

I am using the output classified reads from krakenuniq within taxprofiler and noticed that when i am using illumina (PE) i get .unmapped.merged.unclassified.fasta.gz files. These contains the merged classified reads in fasta format. But when running taxprofiler using iontorrent data (SE) the output is .classified.fasta.gz. Looking into these files the reads are not in fasta format but in fastq. I dont know if this is an issue in taxprofiler or if this is coupled directly to krakenuniq.

Version of taxprofiler used is 1.1.5

Thank you so much for your help and for this great tool!

Command used and terminal output

# Run from iontorrent
gunzip -c 020_KV15-3173-D1-211101_446-996_211102_Run1.classified.fasta.gz | head

@U6L9C:07999:12907
TGGCATTTTTTTTGTCCACTGAAGTTTTAATTTTCTATGCCTGATCAATGTTTATCTAAGGACTTTCCTTTATGGCTTATGCAGACTTGGGATATTTGCCAGGAAAGGCCTTCCATACCAGCCCTGACCTGG
+
054958888888$5::7<>><<7;;::-:0888*8;::996//////)////)///5/262///8/6267066745505988876..)..).667737:5:;6:?4;06-3-30556:0666:17777311+
@U6L9C:08007:12909
GTGACAGTAGGGGAACCTGTCAAAAGAAAGGAGGGAATGGGAAGGAGTGTAGTGGAGTGTTGTGGAGTGGAGTGGAGTGGAATTGGAGATTAATGTAACGGAGTGGAGTGG
+
88;<<<<<<<<<7<7<9=<<==A>7=<<4;6888.87==>8=9>9>=;;;<<<<7<==;;6;<<6<>8818==<8=<;;4;4;5;8<<<=4:5:::<6<;4::67/58883
@U6L9C:07996:13114
CTTGAAGTTTCATTCGAGTTTCCTCAAAACAGCTATTGAATTCACTATACTGAAAGGTCGCATTACGCTCTGTCTTTCATGGAATTAGTTCCGTGGTAGCTTTATTTAATTCATCATGGTGTGGTCAT

# run from illumina
gunzip -c KV19-3902-MetaVal-DNA_240328_run1.unmapped.merged.classified.fasta.gz | head

>NB501037:997:H23YNAFX7:1:11102:6373:17697
GTATAATTATTCTTTACTGTCTTATTCTTTTCACTTTACATTATACATGCACATACCATGATTAAATACTTTGTTGCTAAAAATGCTAATGATCCCCTGAGCCTTCAGCAAGTTGTAATCTTTTTGCTGGTGGAGAGTCTTCCTTCAATNTTGGCCATCAACATTGAAGGAAGACTCTCCACCAGCAAAAAGATTACAACTTGCTGAAGGCTCAGGGGATCATTAGCATTTTTAGCAACAAAGTATTTAATCATGGTATGTGCATGTATAATGTAAAGTGAAAAGAATAAGACAGTAA
>NB501037:997:H23YNAFX7:1:11102:20152:17704
GTATTTGAAGTCAAAAGACTTGGTTTGATTCATTTTGTGACTTTTCCTCCTGGTAAATGACATATACACTCATTTATAGCCATTCATGATGTTCAAAGCTATTTGCCTTAACTTGTCCCTGAATATGCATGCACCACTACGGCCGGCTANGCAGATCACCTGAGGTAGGGAGTTCAAGACCAGCCTGACCAACATGAAGAAACCCCCATCTCTATTAGAAATACAAAATTAGCCGGCCGTAGTGGTGCATGCATATTCAGGGACAAGTTAAGGCAAATAGCTTTGAACATCATGAATGG

Relevant files

No response

System information

No response

@SannaAb SannaAb added the bug Something isn't working label Apr 17, 2024
@jfy133 jfy133 self-assigned this Apr 18, 2024
@jfy133 jfy133 added this to the 1.1.7 - Patch milestone Apr 18, 2024
@jfy133
Copy link
Member

jfy133 commented Apr 18, 2024

Hi @SannaAb ,

Huh ok interesting. Can you confirm: are your input reads for both Illumina and iontorrent FASTQ or FASTA?

I'm wonderinf KrakenUniq just spits out reads in the same format as the input? In which case, yeah we made a false assumption in the module thinking the output is always FASTA but maybe it is not.

@jfy133
Copy link
Member

jfy133 commented Apr 18, 2024

OK I think we've found the case:

KrakenUniq automatically can read internally either FASTA or FASTQ, but it forces you to 'name' the entire output file yourself (including extension). I think we made a faulty assumption(? - @Midnighter ) it's always FASTA, whereas it'll actually just spit out the same format as was given as input.

We will need to update the module to 'auto-detect' the input format, and save the classified reads with the same suffix.

@jfy133
Copy link
Member

jfy133 commented Apr 18, 2024

And we will do a 1.1.7 patch release with a couple of other bug fixes very soon :)

@Midnighter
Copy link
Collaborator

I see now the relation to your other comment. sigh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants