Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KrakenUniq classified reads output format mismatch #489

Merged
merged 5 commits into from
May 21, 2024
Merged

Fix KrakenUniq classified reads output format mismatch #489

merged 5 commits into from
May 21, 2024

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented May 16, 2024

Closes #474

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/taxprofiler branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 marked this pull request as draft May 16, 2024 11:09
@github-actions GitHub Actions
Copy link

github-actions bot commented May 16, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit d5d82b1

+| ✅ 258 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in ci.yml: You can customise CI pipeline run tests as required

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-05-16 14:08:30

@jfy133 jfy133 marked this pull request as ready for review May 16, 2024 12:16
Midnighter
Midnighter requested changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@Midnighter Midnighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions for the regex. If you remove the dumps, then this looks very good to me!

subworkflows/local/profiling.nf Outdated Show resolved Hide resolved
jfy133
jfy133 commented May 16, 2024
View reviewed changes
Copy link
Member Author

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh me and my dumps...

thanks @Midnighter ! I will check with the regex more closely when I have a little more time.

My regex-fu is very poor compared to you, for clarification: I took the 'easier' route as the files are what the module produces and should be fixed (so shouldn't deviate much), but overall more security the better - so I will check and ensure your regex works and then accept it 👍

subworkflows/local/profiling.nf Outdated Show resolved Hide resolved
subworkflows/local/profiling.nf Outdated Show resolved Hide resolved
subworkflows/local/profiling.nf Outdated Show resolved Hide resolved
subworkflows/local/profiling.nf Outdated Show resolved Hide resolved
@jfy133 @Midnighter
Apply suggestions from code review
d5d82b1 
Co-authored-by: Moritz E. Beber <midnighter@posteo.net>
@jfy133
Copy link
Member Author

jfy133 commented May 19, 2024 •
edited
Loading

@Midnighter looks like it works as expected 👍 thank you!

image

If you're happy now please give a ✅ and I will merge!

@jfy133 jfy133 requested a review from Midnighter May 19, 2024 18:41
Midnighter
Midnighter approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@Midnighter Midnighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for implementing it in the pipeline ☺️

@jfy133 jfy133 merged commit dc285e0 into dev May 21, 2024
24 checks passed
@jfy133 jfy133 deleted the ku-fix branch May 21, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Midnighter Midnighter Midnighter approved these changes

@sofstam sofstam Awaiting requested review from sofstam

@LilyAnderssonLee LilyAnderssonLee Awaiting requested review from LilyAnderssonLee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfy133 @Midnighter