Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important! Template update for nf-core/tools v2.10 #380

Merged
merged 5 commits into from
Sep 27, 2023

Conversation

nf-core-bot
Copy link
Member

Version 2.10 of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-2.10 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see https://nf-co.re/docs/contributing/sync/.

For more information about this release of nf-core/tools, please see the v2.10 release page.

@github-actions
Copy link

github-actions bot commented Sep 27, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 53d29f0

+| ✅ 159 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-09-27 11:45:51

solve the conflicts caused by multiQC version
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

CHANGELOG.md Show resolved Hide resolved
lib/WorkflowTaxprofiler.groovy Outdated Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
@jfy133 jfy133 self-requested a review September 27, 2023 12:40
@LilyAnderssonLee LilyAnderssonLee merged commit aecc88b into dev Sep 27, 2023
26 checks passed
@LilyAnderssonLee LilyAnderssonLee deleted the nf-core-template-merge-2.10 branch September 27, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants