Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix krakenuniq reads output #421

Merged
merged 5 commits into from
Nov 23, 2023
Merged

Fix krakenuniq reads output #421

merged 5 commits into from
Nov 23, 2023

Conversation

Midnighter
Copy link
Collaborator

In essence, the fix was done on the module level and this PR simply updates the module pulling in the fix. It seems to me that that is all that's needed.

PR checklist

@Midnighter Midnighter self-assigned this Nov 22, 2023
Copy link

github-actions bot commented Nov 22, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit bcb0539

+| ✅ 159 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-11-23 13:09:12

@jfy133
Copy link
Member

jfy133 commented Nov 23, 2023

long help text in schema needs updating

@jfy133
Copy link
Member

jfy133 commented Nov 23, 2023

and testing failed for me, I guess because modules.conf not udpated with the new pattern?

@Midnighter Midnighter merged commit aab50a5 into dev Nov 23, 2023
26 checks passed
@Midnighter Midnighter deleted the fix-krakenuniq branch November 23, 2023 23:23
@jfy133
Copy link
Member

jfy133 commented Nov 24, 2023

Thanks @Midnighter !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants