Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Taxpasta update to reduce pipeline failures from overly strict profile validation #495

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jun 12, 2024

As reported by multiple on slack and the taxpasta github repo

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/taxprofiler branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

github-actions bot commented Jun 12, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 0a3ce1c

+| ✅ 257 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in ci.yml: You can customise CI pipeline run tests as required

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-06-13 10:42:50

CHANGELOG.md Outdated Show resolved Hide resolved
conf/modules.config Show resolved Hide resolved
Co-authored-by: Sofia Stamouli <91951607+sofstam@users.noreply.github.com>
@jfy133 jfy133 merged commit 5393e35 into dev Jun 19, 2024
24 checks passed
@jfy133 jfy133 deleted the taxpasta-update branch June 19, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants