-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add small files to tower.yml #505
Add small files to tower.yml #505
Conversation
|
@LilyAnderssonLee I think you were a bit overboard. The idea is to be able to visualize quickly text file and html reports (cf https://github.com/nf-core/rnaseq/blob/dev/tower.yml). cf https://docs.seqera.io/platform/23.4.0/reports/overview#limitations |
Ok, I will update it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry did not see @maxulysse review, please address his suggestions and fix failing test before merging (if they do not run this time correctly, I relaunched it at it seems to me a network issue but not sure)
@LilyAnderssonLee do you know how fancythe TSV viewer is? If you can do filtering of tables indeed makes sense to include the taxonomic profiles, but if not I'm not sure the utility of inmcluding those. HTML reports makes sense, asn does maybe log files, but otherwise...? |
@jfy133 TBH I am not sure about the TSV viewer. I have never run taxprofiler on tower yet. It seems tower reports only support these formats: HTML, csv, tsv, pdf, and txt. |
I have a feeling some of the tables will fail to render properly as extension is But I think we can review this and fix it in the future release, once we have a fulltest run to inspect the output files :) |
Add output files information to the file
tower.yml
.Close #373
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).