Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install modules from custom repository ignores -b parameter #1218

Closed
jfy133 opened this issue Jul 23, 2021 · 2 comments
Closed

Install modules from custom repository ignores -b parameter #1218

jfy133 opened this issue Jul 23, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@jfy133
Copy link
Member

jfy133 commented Jul 23, 2021

Description of the bug

I would like to install an in development module from my fork into my pipeline.

nf-core modules install correctly picks up -r jfy133/modules, installing a version corresponding to modules/jfy133/modules/damageprofiler/.

However, this installs whatever is on master, and not the branch, even though the branch is specified with -b.

🧬 10:16:10 with 7GiB/15GiB in archaeodiet on  dsl2 via 🅒 nf-core ❯ nf-core modules -r jfy133/modules -b damageprofiler-update install damageprofiler

                                          ,--./,-.
          ___     __   __   __   ___     /,-._.--~\
    |\ | |__  __ /  ` /  \ |__) |__         }  {
    | \| |       \__, \__/ |  \ |___     \`-._,-`-,
                                          `._,._,'

    nf-core/tools version 2.0.1



? Select 'damageprofiler' version: Rename software/ directory to modules/ to re-organise module structure (#567) e937c7950af70930d1f34bb961403d9d2aa81c7d
INFO     Installing damageprofiler                                                                                                                                                                            install.py:168
INFO     Downloaded 3 files to ./modules/jfy133/modules/damageprofiler           

Hash here is e937c7950af70930d1f34bb961403d9d2aa81c7d, whereas the latest hash of that module on the branch is

image

Steps to reproduce

Steps to reproduce the behaviour:

  1. Command line: nf-core modules -r jfy133/modules -b damageprofiler-update install damageprofiler

Expected behaviour

Also correctly picks up branch.

System

  • Hardware: Laptop
  • OS: Ubuntu 20.04
  • Version of nf-core/tools: 2.0.1
  • Python version: 3.6.12
@jfy133 jfy133 added the bug Something isn't working label Jul 23, 2021
@jfy133
Copy link
Member Author

jfy133 commented Jul 26, 2021

Is -r a bit confusing for this? That means release / branch / tag in other commands (eg. launch).

(Same as Nextflow )

From ☝️ also fair point from @ewels (https://nfcore.slack.com/archives/CE5LG7WMB/p1627116833309500?thread_ts=1627028868.304100&cid=CE5LG7WMB)

@ErikDanielsson
Copy link
Contributor

Closing due to the merge of #1219.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants