Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nf-core branding from pipeline template #1548

Closed
drpatelh opened this issue May 6, 2022 · 5 comments
Closed

Remove nf-core branding from pipeline template #1548

drpatelh opened this issue May 6, 2022 · 5 comments
Labels
template nf-core pipeline/component template

Comments

@drpatelh
Copy link
Member

drpatelh commented May 6, 2022

Description of feature

It would be awesome if we can have an option to remove the nf-core branding when creating pipelines and for this to work with all of the existing tooling we have.

A few members in the community including myself have created a number of pipelines now using the template but they arent likely to be contributed back to nf-core. Having this option saves having to manually replace bits everywhere.

We have some docs to do this manually on the website here but the idea is to replace most of this with a single command! 🔥

@robsyme (just sent you an invite to become a member of the community 🚀 ) has offered to help with the implementation.

I will let him fill in the details but some preliminary discussion was initiated on Slack here

The main complication will be how we get downstream tools like the linting, sync etc to play nicely with non-nf-core branded pipelines. We should add tests for this via Github Actions.

@Midnighter
Copy link
Contributor

What was brought up in the discussion as well, is to add a flag when creating the pipeline to avoid the branding. Maybe it is easier to have options in the various jinja templates that avoids creating the files/sections related to branding.

@drpatelh drpatelh added the template nf-core pipeline/component template label May 6, 2022
@ewels
Copy link
Member

ewels commented May 6, 2022

What kind of stuff do you guys consider branding? I can think of obvious things like the logo in the readme, but not so much beyond that. Do you care about things like lib/* filenames etc or how far are you going down that road?

@drpatelh
Copy link
Member Author

drpatelh commented May 6, 2022

We should collect a list of any filenames, variables, comments, images that are using "nf-core" / "Nfcore" / etc and ideally replace as much as we can either with --prefix or something more generic to save having to use Jinja templating, renaming files etc. This should hopefully also make things easier to maintain in the long run if we do it right once.

@Midnighter
Copy link
Contributor

or something more generic

Naming them for their purpose irrespective of nf-core gets my vote 👍🏼

What kind of stuff do you guys consider branding?

Good question 🙂

Things I thought of:

  1. Printed banner/logo when running the pipeline
  2. Project/pipeline being named nf-core-*
  3. Apple in the logo

I think it would be fair to add a footer in the README that says, "generated with the nf-core tools template" or a similar message on non-branded projects. This is quite common, provides some attribution, but doesn't cause confusion on whether a project is nf-core or not.

@ErikDanielsson
Copy link
Contributor

Closing due to merge of #1551.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
template nf-core pipeline/component template
Projects
None yet
Development

No branches or pull requests

4 participants