Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint for singularity image parsing #1654

Closed
ewels opened this issue Jun 22, 2022 · 1 comment · Fixed by #1683
Closed

Lint for singularity image parsing #1654

ewels opened this issue Jun 22, 2022 · 1 comment · Fixed by #1683
Assignees
Labels

Comments

@ewels
Copy link
Member

ewels commented Jun 22, 2022

When running nf-core download you can sometimes get the following error log message:

ERROR    Cannot parse container string, skipping: ${            download.py:485
         workflow.containerEngine ==   

On the plus side, it doesn't fail. But the error message isn't super useful (would be good to log which file it came from).

More importantly, we should add a lint test to check pipelines that all container strings can be parsed, to avoid this happening in the first place.

@ewels ewels added the linting label Jun 22, 2022
@ErikDanielsson ErikDanielsson linked a pull request Jul 19, 2022 that will close this issue
4 tasks
@ErikDanielsson
Copy link
Contributor

Closing due to merge of #1683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants