Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running nf-core modules update --save-diff when file was created or removed #1694

Closed
ErikDanielsson opened this issue Jul 22, 2022 · 1 comment · Fixed by #1698
Closed

Running nf-core modules update --save-diff when file was created or removed #1694

ErikDanielsson opened this issue Jul 22, 2022 · 1 comment · Fixed by #1698
Assignees
Labels
bug Something isn't working

Comments

@ErikDanielsson
Copy link
Contributor

ErikDanielsson commented Jul 22, 2022

Description of the bug

nf-core modules update --save-diff promises that it can write module changes to a .diff file, and then complete the update with git apply <diff-file>. If a file was removed or created, this is written as a message in the .diff file. However, git apply can't use this information, not for removing files and in particular not for creating files since the file is not available. This will lead to bugs, since the command promises more than it can deliver. I would therefore suggest that the command fails if the update involves removing or creating files, and instead suggest that the user use either the plain update command or the --preview option

Command used and terminal output

nf-core modules update --save-diff

System information

nf-core/tools 2.5dev

@ErikDanielsson
Copy link
Contributor Author

Closing due to merge of #1698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant