Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container Base Url support when creating new modules #1948

Closed
apeltzer opened this issue Oct 13, 2022 · 1 comment
Closed

Container Base Url support when creating new modules #1948

apeltzer opened this issue Oct 13, 2022 · 1 comment

Comments

@apeltzer
Copy link
Member

apeltzer commented Oct 13, 2022

Description of feature

nf-core/modules#2291 outlines how we will restructure to use params.container_registry for docker containers in the future, e.g. to allow using container mirrors from ECR or potentially other sources.

This means however, that we will have to adjust tools code to query the biocontainers API and split the URL
to use the params.container_registry placeholder. Otherwise users might create new modules using nf-core tooling and have full URLs to quay.io in their newly created module code, which is a bit inconvient. Potentially could also lint for this.

x-ref: nf-core/modules#2291 (comment)

@ewels
Copy link
Member

ewels commented Jun 27, 2023

Now using docker registry setting, so this can be closed.

@ewels ewels closed this as completed Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants