Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier fails linting for default modules.json #2047

Closed
drpatelh opened this issue Nov 23, 2022 · 3 comments
Closed

Prettier fails linting for default modules.json #2047

drpatelh opened this issue Nov 23, 2022 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@drpatelh
Copy link
Member

drpatelh commented Nov 23, 2022

Description of the bug

The modules.json was created using nf-core modules and nf-core subworkflows commands using the latest code on dev. However, linting fails with Prettier which wants to put the installed_by section on a single line. We should either ignore this file or fix the default output from tools.

                    "ataqv/ataqv": {
                         "branch": "master",
                         "git_sha": "56421e1a812bc2f9e77dbe9f297e9d9c580cb8a5",
-                        "installed_by": [
-                            "modules"
-                        ]
+                        "installed_by": ["modules"]
                     },
@drpatelh drpatelh added the bug Something isn't working label Nov 23, 2022
@fabianegli
Copy link
Contributor

I think we are moving to run Prettier automatically after any command modifying Prettier formatted files. Once we get this we can also remove some hacks from the code to comply with formatting that are applied to some file dumping functions.

@fabianegli
Copy link
Contributor

In this respect it would be nice to get the actual invocations that mess up the files to start figuring out all the places we need to invoke Prettier.

@ewels
Copy link
Member

ewels commented Nov 29, 2022

Prettier PR now merged, so just a case of using that function on this file after modification.

@ewels ewels added this to the 2.7 milestone Nov 29, 2022
@mashehu mashehu closed this as completed Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants