Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module authors not being added to meta yml #2119

Closed
mahesh-panchal opened this issue Dec 9, 2022 · 1 comment · Fixed by #2120
Closed

Module authors not being added to meta yml #2119

mahesh-panchal opened this issue Dec 9, 2022 · 1 comment · Fixed by #2120
Labels
bug Something isn't working

Comments

@mahesh-panchal
Copy link
Member

Description of the bug

When creating a new module, the module author is not added to bottom of the meta.yml. It's written as "None" instead.

output in meta.yml:

...
authors:
  - "None"

Command used and terminal output

$ nf-core modules create purgedups/getseqs

                                          ,--./,-.
          ___     __   __   __   ___     /,-._.--~\
    |\ | |__  __ /  ` /  \ |__) |__         }  {
    | \| |       \__, \__/ |  \ |___     \`-._,-`-,
                                          `._,._,'

    nf-core/tools version 2.7.1 - https://nf-co.re


INFO     Repository type: modules                                                                                                                                                              
INFO     Press enter to use default values (shown in brackets) or type your own responses. ctrl+click underlined text to open links.                                                           
WARNING  Could not find Conda dependency using the Anaconda API: 'purgedups'                                                                                                                   
Do you want to enter a different Bioconda package name? [y/n]: y
Name of Bioconda package: purge_dups
INFO     Using Bioconda package: 'bioconda::purge_dups=1.2.6'                                                                                                                                  
INFO     Could not find a Docker/Singularity container (Unexpected response code `503` for https://api.biocontainers.pro/ga4gh/trs/v2/tools/purge_dups/versions/purge_dups-1.2.6)              
GitHub Username: (@author): @mahesh-panchal
INFO     Provide an appropriate resource label for the process, taken from the nf-core pipeline template.                                                                                      
         For example: process_single, process_low, process_medium, process_high, process_long                                                                                                  
? Process resource label: process_single
INFO     Where applicable all sample-specific information e.g. 'id', 'single_end', 'read_group' MUST be provided as an input via a Groovy Map called 'meta'. This information may not be       
         required in some instances, for example indexing reference genome files.                                                                                                              
Will the module require a meta map of sample information? [y/n] (y): y
INFO     Created / edited following files:                                                                                                                                                     
           ./modules/nf-core/purgedups/getseqs/main.nf                                                                                                                                         
           ./modules/nf-core/purgedups/getseqs/meta.yml                                                                                                                                        
           ./tests/modules/nf-core/purgedups/getseqs/main.nf                                                                                                                                   
           ./tests/modules/nf-core/purgedups/getseqs/test.yml                                                                                                                                  
           ./tests/modules/nf-core/purgedups/getseqs/nextflow.config                                                                                                                           
           ./tests/config/pytest_modules.yml

System information

Nextflow version: version 22.10.1
Hardware: Cloud (Gitpod)
Executor: local
OS: Unix (Gitpod)
nf-core/tools: 2.7.1
python: 3.9.15

@mahesh-panchal mahesh-panchal added the bug Something isn't working label Dec 9, 2022
@awgymer
Copy link
Contributor

awgymer commented Dec 9, 2022

I guess we don't have a test to check that file and the author section, because this is due to us not returning from the get_username method in components_create

And actually I think even if we did we are not assigning the result properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants