Is branch checking broken?

[fabianegli]

Possibly not, but how does

[[ $GITHUB_HEAD_REF = "dev" ]]

make any sense? Shouldn't it be

[[ $GITHUB_HEAD_REF == "dev" ]]?

After all, it's a comparison - and single = are normally assignments. But there might be some hidden Bash sorcery at work that I don't understand...

See:

tools/.github/workflows/branch.yml

Line 16 in 4a29080

{ [[ ${{github.event.pull_request.head.repo.full_name}} == nf-core/tools ]] && [[ $GITHUB_HEAD_REF = "dev" ]]; } || [[ $GITHUB_HEAD_REF == "patch" ]]

Introduced in f499c3f

[fabianegli]

OK, so there is the possibility to use either == or = for comparisons within [[ in Bash. See: https://www.gnu.org/software/bash/manual/html_node/Bash-Conditional-Expressions.html

I still think it is better to harmonize the synthax.

[fabianegli]

Closed by #2203