Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read docker.registry configuration when checking containers exist #2310

Closed
adamrtalbot opened this issue Jun 9, 2023 · 1 comment
Closed
Milestone

Comments

@adamrtalbot
Copy link
Contributor

Description of feature

Currently, the nf-core modules lint can confirm a docker container exists at the remote registry when linting a module. However, if the container name is simple it expects it to be hosted on quay.io. Instead, we should respect docker.registry which may be set to something else. As a simple option, this could be added as a command line parameter e.g. --registry public.ecr.aws until we can automatically read it from the configuration.

@mashehu
Copy link
Contributor

mashehu commented Jun 19, 2023

Fixed in #2318

@mashehu mashehu closed this as completed Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants