Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong links in "assets/multiqc_config.yml" #2361

Closed
drpatelh opened this issue Jul 4, 2023 · 3 comments
Closed

Wrong links in "assets/multiqc_config.yml" #2361

drpatelh opened this issue Jul 4, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@drpatelh
Copy link
Member

drpatelh commented Jul 4, 2023

Description of the bug

The link rendered when the pipeline template below doesn't work:

This report has been generated by the <a href="https://github.com/{{ name }}/{{ version}}" target="_blank">{{ name }}</a>

I believe it should be href="https://github.com/{{ name }}/tree/{{ version}}"

Also, a related question. Will the link below work on the website if for example I have a dev version of a pipeline defined in manifest.version e.g. 3.13.0dev. Could be another bug there too.

<a href="https://nf-co.re/{{ short_name }}/{{ version }}/output" target="_blank">documentation</a>.{% endif %}

@maxulysse
Copy link
Member

I had the dev in sarek, something is weird there

@SusiJo
Copy link
Contributor

SusiJo commented Jul 6, 2023

Is this wrong link related to this linting error?

[✗] 1 Pipeline Test Failed                                                                           
multiqc_config: 'assets/multiqc_config.yml' does not contain a matching 'report_comment'.                                                          

@SusiJo
Copy link
Contributor

SusiJo commented Jul 6, 2023

The linting of the multiqc_config

version = self.nf_config.get("manifest.version", "").strip(" '\"")
checks for the manifest.version in the nextflow.config. However, if the dev branch has a version string like manifest.version = '2.1.0dev'. There will not be any such tag available for creating the link described above.
So maybe the manifest.version should be taken from the nextflow.config of the master branch or the dev string removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants