Linting failure appearing on subworkflows even without deprecated section

[anoronh4]

Description of the bug

Getting the lint failure: Deprecated section 'modules' not found in meta.yml on current nf-core subworkflows. Not sure i understand this failure, based on the code it looks like i might be getting this failure no matter what:

tools/nf_core/subworkflows/lint/meta_yml.py

Lines 117 to 132 in 9ab896c

	if "modules" in meta_yaml:
	subworkflow.failed.append(
	(
	"meta_modules_deprecated",
	f"Deprecated section 'modules' found in `meta.yml`, use 'components' instead",
	subworkflow.meta_yml,
	)
	)
	else:
	subworkflow.failed.append(
	(
	"meta_modules_deprecated",
	f"Deprecated section 'modules' not found in `meta.yml`",
	subworkflow.meta_yml,
	)
	)

I am finding this on current subworkflows in the nf-core/modules repo.

Command used and terminal output

$ nf-core subworkflows lint fastq_align_star

                                          ,--./,-.
          ___     __   __   __   ___     /,-._.--~\
    |\ | |__  __ /  ` /  \ |__) |__         }  {
    | \| |       \__, \__/ |  \ |___     \`-._,-`-,
                                          `._,._,'

    nf-core/tools version 2.10 - https://nf-co.re


INFO     Linting modules repo: '.'                                                                                                                                         
INFO     Linting subworkflow: 'fastq_align_star'                                                                                                                           

╭─ [!] 2 Subworkflow Test Warnings ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│                                           ╷                                               ╷                                                                             │
│ Subworkflow name                          │ File path                                     │ Test message                                                                │
│╶──────────────────────────────────────────┼───────────────────────────────────────────────┼────────────────────────────────────────────────────────────────────────────╴│
│ fastq_align_star                          │ subworkflows/nf-core/fastq_align_star/main.nf │ Included component 'BAM_SORT_STATS_SAMTOOLS' versions are not added in      │
│                                           │                                               │ main.nf                                                                     │
│ fastq_align_star                          │ subworkflows/nf-core/fastq_align_star/main.nf │ Included component 'STAR_ALIGN' versions are not added in main.nf           │
│                                           ╵                                               ╵                                                                             │
╰─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
╭─ [✗] 1 Subworkflow Test Failed ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│                                           ╷                                                ╷                                                                            │
│ Subworkflow name                          │ File path                                      │ Test message                                                               │
│╶──────────────────────────────────────────┼────────────────────────────────────────────────┼───────────────────────────────────────────────────────────────────────────╴│
│ fastq_align_star                          │ subworkflows/nf-core/fastq_align_star/meta.yml │ Deprecated section 'modules' not found in meta.yml                         │
│                                           ╵                                                ╵                                                                            │
╰─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
╭───────────────────────╮
│ LINT RESULTS SUMMARY  │
├───────────────────────┤
│ [✔] 134 Tests Passed  │
│ [!]   2 Test Warnings │
│ [✗]   1 Test Failed   │
╰───────────────────────╯

System information

nextflow version 23.04.4
CentOS7 linux
local executor
HPC
nf-core tools 2.10
python 3.10.8

[anoronh4]

just noticed this was fixed in the dev version of tools with #2447 -- i'll close this issue!