Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add initial intro to meta map #1085

Merged
merged 7 commits into from
Mar 25, 2022
Merged

docs: Add initial intro to meta map #1085

merged 7 commits into from
Mar 25, 2022

Conversation

edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller commented Mar 17, 2022

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a short explanation of what is the meta map and how is it used.

markdown/developers/adding_modules.md Outdated Show resolved Hide resolved
markdown/developers/adding_modules.md Outdated Show resolved Hide resolved
markdown/developers/adding_modules.md Outdated Show resolved Hide resolved
markdown/developers/adding_modules.md Outdated Show resolved Hide resolved
markdown/developers/adding_modules.md Outdated Show resolved Hide resolved
markdown/developers/adding_modules.md Outdated Show resolved Hide resolved
markdown/developers/adding_modules.md Outdated Show resolved Hide resolved
markdown/developers/adding_modules.md Outdated Show resolved Hide resolved
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments for clarity

markdown/developers/adding_modules.md Outdated Show resolved Hide resolved
markdown/developers/adding_modules.md Outdated Show resolved Hide resolved
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice job 😄
Just added some small suggestions but I let you judge wether it is worth including them or not
🚀

markdown/developers/adding_modules.md Outdated Show resolved Hide resolved
markdown/developers/adding_modules.md Outdated Show resolved Hide resolved
edmundmiller and others added 6 commits March 18, 2022 10:40
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Co-authored-by: Jose Espinosa-Carrasco <kadomu@gmail.com>
Co-authored-by: Phil Ewels <phil.ewels@scilifelab.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Documentation for meta map
5 participants